Fixed #5 - Adding support for Google Cloud Storage #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @briandorsey |
| follow the | ||
| (pretty simple) | ||
| instructions in the | ||
| (coming soon...) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
/cc @yuanye-xx |
|
Alright crew, looking to merge this by EOD. A few more hours to get more comments in... CC: @yuanye-xx @proppy @briandorsey |
| :returns: A Http object used to transport data. | ||
| """ | ||
| if not hasattr(self, '_http'): | ||
| self._http = httplib2.Http() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Alright @proppy : Addressed most comments, would love to merge this soon so we can have a proper storage API client that works. We're still in the "alpha" stages, so we have a bit of leeway to change things down the line, particularly if they're non-breaking. I think first step is to ticket out the issues brought up in the PR, then fix #22 to avoid regressions. Can I get an overall "+1 this is good enough"? |
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/python-webrisk/compare/v1.2.0...v1.3.0) (2021-06-01) ### Features * bump release level to production/stable ([#81](https://www.github.com/googleapis/python-webrisk/issues/81)) ([0946b75](https://www.github.com/googleapis/python-webrisk/commit/0946b753e9371a4f275035cf35b11fd6b5b5464e)), closes [#20](https://www.github.com/googleapis/python-webrisk/issues/20) ### Bug Fixes * **deps:** add packaging requirement ([#82](https://www.github.com/googleapis/python-webrisk/issues/82)) ([4ec0245](https://www.github.com/googleapis/python-webrisk/commit/4ec0245957d14816bd3ed293e617f5cf830850f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
… `TagTemplateField` in v1beta1; rename `field_path` to `tag_template_field_path` in v1beta1; add pagination support to `list_taxonomies` in v1beta1 (#20) * [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * docs: add multiprocessing Co-authored-by: Bu Sun Kim <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [0.8.0](https://www.github.com/googleapis/python-datacatalog/compare/v0.7.0...v0.8.0) (2020-05-20) ### Features * add `restricted_locations` to v1; add `order` to `TagField` and `TagTemplateField` in v1beta1; rename `field_path` to `tag_template_field_path` in v1beta1; add pagination support to `list_taxonomies` in v1beta1 ([#20](https://www.github.com/googleapis/python-datacatalog/issues/20)) ([7a890c2](https://www.github.com/googleapis/python-datacatalog/commit/7a890c2f87ff37f610c7246bcbf369314d87b93d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/131dd10e-845c-4b68-acf1-3514a23e446f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@cf2eff0 Source-Link: googleapis/synthtool@db4f15f Source-Link: googleapis/synthtool@cd522c3 PiperOrigin-RevId: 316182409 Source-Link: googleapis/googleapis@1846617 Source-Link: googleapis/synthtool@4e1d2cb Source-Link: googleapis/synthtool@e99975b Source-Link: googleapis/synthtool@ffe1040 Source-Link: googleapis/synthtool@71b8a27 PiperOrigin-RevId: 313460921 Source-Link: googleapis/googleapis@c4e3701 PiperOrigin-RevId: 312689208 Source-Link: googleapis/googleapis@dec3204 Source-Link: googleapis/synthtool@d2364eb PiperOrigin-RevId: 312088359 Source-Link: googleapis/googleapis@5a90d46 Source-Link: googleapis/synthtool@7482e79 Source-Link: googleapis/synthtool@09c4846 PiperOrigin-RevId: 309824146 Source-Link: googleapis/googleapis@e0f9d9e
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Source-Author: Dan O'Meara <[email protected]> Source-Date: Mon Jun 29 13:20:01 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 303271797a360f8a439203413f13a160f2f5b3b4 Source-Link: googleapis/synthtool@3032717
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
parthea
pushed a commit
that referenced
this pull request
Jun 5, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
parthea
added a commit
that referenced
this pull request
Aug 15, 2023
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.1](https://www.github.com/googleapis/python-iam/compare/v1.0.0...v1.0.1) (2020-06-29) ### Bug Fixes * update default retry config ([#21](https://www.github.com/googleapis/python-iam/issues/21)) ([840de7e](https://www.github.com/googleapis/python-iam/commit/840de7e974f1214d420d7ff9fc990cd9710baa66)) ### Documentation * fix a tiny typo in the README ([#20](https://www.github.com/googleapis/python-iam/issues/20)) ([ef36fe8](https://www.github.com/googleapis/python-iam/commit/ef36fe8eac9b0ff6bd57132c71135718c3c55f9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
parthea
pushed a commit
that referenced
this pull request
Sep 14, 2023
Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea
pushed a commit
that referenced
this pull request
Sep 14, 2023
* docs: add long timeout code snippet * fix lint * add timeout
parthea
pushed a commit
that referenced
this pull request
Sep 20, 2023
Source-Link: googleapis/synthtool@993985f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Add packaging requirement. packaging.version
is used for a version comparison in transports/base.py and is needed after the upgrade to gapic-generator-python 0.46.3
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [0.2.0](https://www.github.com/googleapis/python-appengine-admin/compare/v0.1.0...v0.2.0) (2021-05-28) ### Features * support self-signed JWT flow for service accounts ([c798db2](https://www.github.com/googleapis/python-appengine-admin/commit/c798db287a2e85551e512e66d4bc1da344a806d2)) ### Bug Fixes * add async client to %name_%version/init.py ([c798db2](https://www.github.com/googleapis/python-appengine-admin/commit/c798db287a2e85551e512e66d4bc1da344a806d2)) * **deps:** add packaging requirement ([#20](https://www.github.com/googleapis/python-appengine-admin/issues/20)) ([f352b81](https://www.github.com/googleapis/python-appengine-admin/commit/f352b811c13dd4b5b9fecf719dad05ce292e61fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Source-Link: googleapis/synthtool@da93087 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:899d5d7cc340fa8ef9d8ae1a8cfba362c6898584f779e156f25ee828ba824610 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore: update Py2 support msg to reflect passage of time
Source-Author: Dan O'Meara <[email protected]>
Source-Date: Mon Jun 29 13:20:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 303271797a360f8a439203413f13a160f2f5b3b4
Source-Link: googleapis/synthtool@3032717
* chore: fix docstring in pb2
Co-authored-by: Bu Sun Kim <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [0.2.0](https://www.github.com/googleapis/python-analytics-admin/compare/v0.1.0...v0.2.0) (2021-01-20) ### ⚠ BREAKING CHANGES * `update_mask` field is required for all Update operations * rename `country_code` field to `region_code` in `Account` * rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings` * remove `parent` field from `GoogleAdsLink` * remove unused fields from `EnhancedMeasurementSettings` (#29) ### Features * add ListAccountSummaries ([#20](https://www.github.com/googleapis/python-analytics-admin/issues/20)) ([04d05d7](https://www.github.com/googleapis/python-analytics-admin/commit/04d05d7436a752dba18cb04d0e6882b1670114d7)) * add pagination support for `ListFirebaseLinks` operation ([bc756a9](https://www.github.com/googleapis/python-analytics-admin/commit/bc756a9566497ab6ff997d26d7fa35c9a6355ecf)) ### Bug Fixes * `update_mask` field is required for all Update operations ([bc756a9](https://www.github.com/googleapis/python-analytics-admin/commit/bc756a9566497ab6ff997d26d7fa35c9a6355ecf)) * remove `parent` field from `GoogleAdsLink` ([bc756a9](https://www.github.com/googleapis/python-analytics-admin/commit/bc756a9566497ab6ff997d26d7fa35c9a6355ecf)) * remove unused fields from `EnhancedMeasurementSettings` ([#29](https://www.github.com/googleapis/python-analytics-admin/issues/29)) ([bc756a9](https://www.github.com/googleapis/python-analytics-admin/commit/bc756a9566497ab6ff997d26d7fa35c9a6355ecf)) * rename `country_code` field to `region_code` in `Account` ([bc756a9](https://www.github.com/googleapis/python-analytics-admin/commit/bc756a9566497ab6ff997d26d7fa35c9a6355ecf)) * rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings` ([bc756a9](https://www.github.com/googleapis/python-analytics-admin/commit/bc756a9566497ab6ff997d26d7fa35c9a6355ecf)) ### Documentation * added a sample ([#9](https://www.github.com/googleapis/python-analytics-admin/issues/9)) ([60918d8](https://www.github.com/googleapis/python-analytics-admin/commit/60918d8896d37f32a19c3d5724611df5cc4d4619)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
This is the sibling PR to GoogleCloudPlatform/python-docs-samples#5611 and this is the issue opened for it GoogleCloudPlatform/python-docs-samples#5549
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:0856ca711da1fd5ec9d6d7da6c50aa0bbf550fb94acb47b55159a640791987bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things still remaining, but I think we're OK even without these...
@proppy : Thoughts?